New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix very slow startup caused by getSelectorDeprecationsCount() called many times #54

Merged
merged 1 commit into from Jun 22, 2015

Conversation

Projects
None yet
3 participants
@ypresto
Contributor

ypresto commented Jun 19, 2015

image

updateDeprecatedSelectorCount() enforces rescanning deprecated selectors.
This method called so many times by atom.packages callbacks.

This PR debouces it and dramatically (>=1000ms) shorten startup time!

@mnquintana

This comment has been minimized.

Show comment
Hide comment
Member

mnquintana commented Jun 21, 2015

kevinsawicki added a commit that referenced this pull request Jun 22, 2015

Merge pull request #54 from ypresto/boost-by-debounce
Fix very slow startup caused by getSelectorDeprecationsCount() called many times

@kevinsawicki kevinsawicki merged commit 722529d into atom:master Jun 22, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kevinsawicki

This comment has been minimized.

Show comment
Hide comment
@kevinsawicki

kevinsawicki Jun 22, 2015

Member

Thanks for this 🏇 💚

Member

kevinsawicki commented Jun 22, 2015

Thanks for this 🏇 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment