This repository has been archived by the owner. It is now read-only.

Cleanup #27

Merged
merged 4 commits into from Nov 12, 2017

Conversation

Projects
None yet
1 participant
@50Wliu
Member

50Wliu commented Nov 12, 2017

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

Tried to separate everything into different commits so that it was clear what I did.

  • Reorganize activation to make a bit more sense - only add the command after initial packages have activated and make sure the onDidActivateInitialPackages subscription is disposed if dev-live-reload activates and then is deactivated before all packages are loaded
  • When testing if a string fragment exists, use .includes rather than .indexOf
  • Use Sets for built-in uniqueness
  • Use Maps to avoid breakage when a package is named __proto__
  • Removed underscore-plus dependency in favor of native methods

Alternate Designs

N/A

Benefits

Easier to understand code.

Possible Drawbacks

Possibility for regressions. I have and will continue to stress test this package before publishing a new release.

Applicable Issues

None.

50Wliu added some commits Nov 12, 2017

@50Wliu 50Wliu merged commit a7c8302 into master Nov 12, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@50Wliu 50Wliu deleted the wl-cleanup branch Nov 12, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.