This repository has been archived by the owner. It is now read-only.

Defer UIWatcher require until needed #31

Merged
merged 1 commit into from Nov 14, 2017

Conversation

Projects
None yet
1 participant
@50Wliu
Member

50Wliu commented Nov 14, 2017

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

This brings down activation time from ~50ms to ~5ms for me in non-dev windows. Don't think we can get any faster than that :P.

Alternate Designs

None.

Benefits

Faster startup time.

Possible Drawbacks

None.

Applicable Issues

None.

Defer UIWatcher require until needed
Brings down activation time from ~50ms to ~5ms for me on non-dev windows

@50Wliu 50Wliu merged commit c7b322c into master Nov 14, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@50Wliu 50Wliu deleted the wl-defer-require branch Nov 14, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.