New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the encoding label unfocusable to properly restore focus #46

Merged
merged 1 commit into from Sep 16, 2017

Conversation

Projects
None yet
2 participants
@jddxf
Contributor

jddxf commented Apr 17, 2017

Description of the Change

Make the encoding label unfocusable.

Alternate Designs

Benefits

We can restore the focus onto the focused element before clicking rather than the encoding label, which in my opinion is desirable in most cases. This change also aligns with behavior of grammar-selector.

Possible Drawbacks

Cannot navigate through tabs. But the navigation actually doesn't make sense since we cannot use Enter when focusing.

Applicable Issues

Part of atom/status-bar#82

@50Wliu 50Wliu self-assigned this Apr 18, 2017

@50Wliu

This comment has been minimized.

Show comment
Hide comment
@50Wliu

50Wliu Sep 16, 2017

Member

Tried pretty hard to test this, but wasn't able to. Otherwise, looks good to me.

Member

50Wliu commented Sep 16, 2017

Tried pretty hard to test this, but wasn't able to. Otherwise, looks good to me.

@50Wliu 50Wliu merged commit e87962f into atom:master Sep 16, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment