This repository has been archived by the owner on Sep 28, 2018. It is now read-only.
Clean up paths when reporting bugs to bugsnag #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
50Wliu
reviewed
Jan 13, 2017
| let normalizePath = path => { | ||
| return path.replace('file:///', '') // Randomly inserted file url protocols | ||
| .replace(/[/]/g, '\\') // Temp switch for Windows home matching | ||
| .replace(fs.getHomeDirectory(), '~') // Remove users home dir for apm-dev'ed packages |
There was a problem hiding this comment.
Missed this before it got merged, but it looks like instead of having to require fs, we can use the already-required os with os.homedir()?
There was a problem hiding this comment.
There are a lot of places where fsplus.getHomeDirectory() is used - we should clean them all up together. I'm assuming we can safely drop the node 0.9 stuff now (os.homedir() was introduced in 2.3)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up the root of paths on bugsnag