New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't modify selection when toggling "only in selection" #1007

Merged
merged 5 commits into from Mar 26, 2018

Conversation

Projects
None yet
1 participant
@smashwilson
Member

smashwilson commented Mar 26, 2018

When toggling "only in selection," only select the first marker after the cursor if there was no actual selection. Otherwise, when this.search() is called immediately before a replaceAll operation, the selection was replaced by the first marker and only the first marker is actually replaced.

Fixes #1005.

smashwilson added some commits Mar 26, 2018

@smashwilson smashwilson merged commit dec5b3b into master Mar 26, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@smashwilson smashwilson deleted the aw/only-replace-first branch Mar 26, 2018

@Arcanemagus Arcanemagus referenced this pull request Apr 19, 2018

Closed

Replace all in selection only replaces first match #1005

1 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment