Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keymaps for home and end to project search #1015

Merged
merged 1 commit into from May 1, 2018

Conversation

Projects
None yet
2 participants
@PoignardAzur
Copy link
Contributor

PoignardAzur commented Apr 21, 2018

Description of the Change

Adds keymaps when pressing "home" and "end" in project search, that trigger ResultsView.moveToTop and ResultsView.moveToBottom respectively.

The code for these methods already existed, but it wasn't linked to any keymaps, and the only way to trigger them was to e.g. write "Core: Move To Top" in the command panel.

Benefits

Being able to quickly select the first/last result in project search using the keyboard.

Alternate Designs, Possible Drawbacks, Applicable Issues

No alternate design, no likely drawback, I don't think any issue was made on the subject.

@PoignardAzur

This comment has been minimized.

Copy link
Contributor Author

PoignardAzur commented Apr 26, 2018

@Ben3eeE

Yeah I used the command from the command-palette. I wouldn't say the command is broken on master. It's just not bound to any keyboard shortcut by default. You could bind it in your personal keymap.

I don't know if it qualifies as broken then, but it's not ideal. Most users wouldn't even think to try typing "move-to-top/bottom", and would just assume the feature doesn't exist.

(also, as a precedent, tree-view does have default keybindings for move-to-top/bottom)

@lee-dohm lee-dohm merged commit cdd04c8 into atom:master May 1, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lee-dohm

This comment has been minimized.

Copy link
Member

lee-dohm commented May 1, 2018

Thanks very much for the help! 🎉

@PoignardAzur PoignardAzur deleted the PoignardAzur:add-home-end-keymaps branch May 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.