Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show find-and-replace "Copy Path" item in tree-view context menu #1035

Merged
merged 1 commit into from Jul 25, 2018

Conversation

Projects
None yet
1 participant
@jasonrudolph
Copy link
Member

jasonrudolph commented Jul 24, 2018

Fixes #1032.


#1032 reports that the selector changes in #1002 cause find-and-replace's "Copy Path" menu item to unintentionally appear in tree-view's context menu. This pull request applies a more specific CSS selector to the "Copy Path" menu item, ensuring that it appears where we want it in the find-and-replace context menu, but not where we don't want it in the tree-view context menu.

The changes in #1002 were first released in find-and-replace v0.215.10. I checked out v0.215.9 to compare the behavior prior to #1002, the behavior in v0.215.10 (after #1002), and the behavior resulting from the changes in this pull request:

version tree-view context menu search results context menu for file search results context menu for line
v0.215.9 Not Present [screenshot] Present [screenshot] Not Present [screenshot]
v0.215.10 Present (Accidentally introduced in #1002) [screenshot] Present [screenshot] Present (Intentionally introduced in #1002) [screenshot]
This Pull Request Not Present [screenshot] Present [screenshot] Present [screenshot]

/fyi @PoignardAzur (author of #1002)
/fyi @sunz7 (author of #1032)

Don't show find-and-replace "Copy Path" item in tree-view context menu
befebde reduced the specificity of the
selector for the "Copy Path" menu item [A], causing the menu item to
appear in the tree-view's context menu. With the changes in this commit,
the "Copy Path" menu item appears in the find-and-replace context menu
for files and lines, but it does not appear in the tree-view context
menu.

[A]
befebde#diff-9d7d0803c9fece359b6cd239f42a2e23L31

@jasonrudolph jasonrudolph self-assigned this Jul 24, 2018

@jasonrudolph jasonrudolph merged commit c56b921 into master Jul 25, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jasonrudolph jasonrudolph deleted the fix-1032 branch Jul 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.