Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded fonts so that search view always use Atom’s font #1061

Merged
merged 1 commit into from Jan 14, 2019

Conversation

Projects
None yet
4 participants
@ariasuni
Copy link
Contributor

ariasuni commented Dec 19, 2018

Description of the Change

Remove the hardcoded font names, so that the package use Atom’s font.

Before (setting the Editor font to Inconsolata):
screenshot_20181220_052703

After:
screenshot_20181220_052831

Alternate Designs

Expose the font used for file names as a configuration option, but I fail to find a compelling use case.

Benefits

Less code, uniform look, don’t need to change several fonts.

Possible Drawbacks

Can’t use another font for file names in search results.

Applicable Issues

Fix #1057

@rsese

This comment has been minimized.

Copy link
Member

rsese commented Dec 20, 2018

Thanks @ariasuni! Can you add before and after screenshots that show the fix?

@ariasuni

This comment has been minimized.

Copy link
Contributor Author

ariasuni commented Dec 20, 2018

I updated my first comment with screenshots. 🙂

@rsese

This comment has been minimized.

Copy link
Member

rsese commented Dec 20, 2018

Thank you! Someone from the team will take a look as soon as they can.

@daviwil

daviwil approved these changes Jan 8, 2019

Copy link
Member

daviwil left a comment

Looks good to me, though I'd certainly appreciate @simurai's opinion on whether this might cause unexpected problems.

@daviwil

This comment has been minimized.

Copy link
Member

daviwil commented Jan 14, 2019

Going to merge this anyway as I think it's a useful change. Thanks again @ariasuni!

@daviwil daviwil merged commit 43ca743 into atom:master Jan 14, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ariasuni ariasuni deleted the ariasuni:fix-hardcoded-fonts branch Jan 15, 2019

@simurai

This comment has been minimized.

Copy link
Member

simurai commented Jan 15, 2019

Sorry for the late reply, but yes.. this is a great fix. 👍 👍 👍 Thanks @ariasuni

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.