Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use editor.onDidStopChanging, not editor.getBuffer().onDidStopChanging #1063

merged 1 commit into from Dec 28, 2018


None yet
1 participant
Copy link

50Wliu commented Dec 28, 2018

Quick follow-up from #966, to definitively make clear that the existence of a buffer does not matter; rather, it is the text editor itself that counts.
There is no change in functionality, as editor.onDidStopChanging directly calls the TextBuffer version.

@50Wliu 50Wliu merged commit e9f68a1 into master Dec 28, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed

@50Wliu 50Wliu deleted the wl-use-editor-directly branch Dec 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.