Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Find within TextEditors within non-editor pane items #1068
Description of the Change
In atom/github, we open several pane items that embed TextEditor elements, but are not TextEditors themselves: ChangedFileItems for single file diffs (stage and unchanged), CommitPreviewItems for commit previews, and the "Files Changed" tab within the pull request detail item. Cmd-F doesn't search them, which is inconvenient, because especially the last two can be large.
To accommodate them, and any other packages that created pane items with internal TextEditors, I'm allowing pane items to implement a
I thought about making the method
It's possible that there are items in third-party packages that already implement a method with that name. Although this is kind of a bonus too?