Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Understand observeEmbeddedTextEditor to follow embedded TextEditor changes #1069

merged 4 commits into from Jan 28, 2019


Copy link

@smashwilson smashwilson commented Jan 25, 2019


  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

This is a follow-on enhancement to #1068. If the active pane item implements observeEmbeddedTextEditor, the find model will track changes to the embedded TextEditor after the pane item activation completes.

Alternate Designs



atom/github will be able to use this API with React refs, which aren't available synchronously on item activation (oops).

Possible Drawbacks


Applicable Issues


@smashwilson smashwilson changed the title Understand onDidChangeEmbeddedTextEditor to follow embedded TextEditor changes Understand observeEmbeddedTextEditor to follow embedded TextEditor changes Jan 25, 2019
@smashwilson smashwilson merged commit 8f09a2d into master Jan 28, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed
@smashwilson smashwilson deleted the aw/accept-a-promise branch Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant