Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle multiline results on the find and replace UI #1085

Merged
merged 2 commits into from May 24, 2019

Conversation

Projects
None yet
2 participants
@rafeca
Copy link
Contributor

commented May 22, 2019

Description of the Change

This PR tweaks the logic of the method that handles results from the search provider to be able to support results that span across multiple lines.

Motivation

The current default scanner (scandal) does not support multiline regexps, so up until now it was rare to get a search result that contained multiple lines, this is why the current UI does not handle them well.

Still, currently there's one situation where multi-line results are shown, which causes a very broken results view (more info), so this PR aims to fix it.

This PR also paves out the support for adding ripgrep as backend for the searches, since ripgrep can return multi-line results (this is going to be added in a separate PR).

Benefits

This will allow find and replace to show multiline results, which is a much requested feature: #303

Possible Drawbacks

Slightly more complex logic for displaying results.

rafeca added some commits May 22, 2019

Handle exceptions thrown by atom.workspace.scan()
This commit makes sure that async exceptions thrown are handled and
displayed correctly in the find and replace UI

@rafeca rafeca force-pushed the ripgrep-option branch from d532ce0 to e2600aa May 22, 2019

@rafeca rafeca requested review from as-cii and nathansobo May 23, 2019

@rafeca rafeca merged commit d4bcc42 into master May 24, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rafeca rafeca deleted the ripgrep-option branch May 24, 2019

@nathansobo
Copy link
Contributor

left a comment

A bit late, but I reviewed it and approve. The comments were helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.