Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul height invalidation #1093

Merged
merged 3 commits into from Jun 26, 2019

Conversation

@nathansobo
Copy link
Contributor

commented Jun 26, 2019

馃崘'd with @as-cii

Fixes atom/atom#19554

In investigating atom/atom#19554, we discovered that every single test that was awaiting the heightInvalidationPromise on its view still passes if we don't await that promise. Since we're concerned that these awaits are the source of timeouts like the one in the linked issue, we decided to completely remove that logic from all tests.

We also took the opportunity to replace element-resize-detector with the native ResizeObserver API which was introduced after the code in this package was written.

Hopefully this addresses all of the remaining flakiness in our tests for this package.

nathansobo and others added some commits Jun 25, 2019

Replace element-resize-detector with native ResizeObserver API
Co-Authored-By: Antonio Scandurra <as-cii@github.com>
Don't await on heightInvalidationPromise in tests
We couldn't find a single test that needed this to pass, and we're 
worried that it's introducing unreliability into the test suite.

Co-Authored-By: Antonio Scandurra <as-cii@github.com>

@nathansobo nathansobo merged commit 2327c9c into master Jun 26, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@nathansobo nathansobo deleted the ns/fix-flakys branch Jun 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can鈥檛 perform that action at this time.