Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Add pcre2 ripgrep option #1095
Description of the Change
Added option to enable
NOTE: I haven't written any specs because I'm not sure what steps to take. Should I wrap all the specs in additional loop, same as prev PR has done with ripgrep support?
NOTE: cannot build Atom ATM so haven't tested the changes locally.
Allows additional regex features such as lookbehind.
Enabling PCRE2 potentially incurs performance penalty, as explained on ripgrep's wiki, thus this PR does not enable it by default, and instead adds an option.
Accompanying PR in atom core
Mhm, seems it didn't work. I have both
EDIT: hold on a minute. I've updated