Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Don’t crash when using find view in tab that’s not an editor #1100
Description of the Change
It is implement in
The fact that now the buttons are disabled and provide a hint of why it is disabled will help people understand why the find/find all feature is unavailable here.
I can’t see any.
I think these changes need unit tests but I find it more difficult to find what should go where and how to implement these tests properly, so any help to get started is appreciated.
Also during my work, I found that I was able make filters unmodifiable (i.e. clicking filters did nothing) when pane was opened on a non-editor page, so that will need to be tested too.
I spotted several bugs introduced by my changes:
Thanks so much for for opening this pull request @ariasuni
Though it's possible someone might jump in with suggestions here, the best place to get help with testing questions is the Atom Slack - not sure if you're on there already, but you can request an invite as detailed in the link.