Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintain previous scroll position #1105

Merged
merged 5 commits into from Nov 14, 2019
Merged

Maintain previous scroll position #1105

merged 5 commits into from Nov 14, 2019

Conversation

darangi
Copy link
Contributor

@darangi darangi commented Nov 8, 2019

Description of the Change

Maintains scroll position after opening a file from the results page.

Benefits

Always keep your last selected search result in focus whenever you return to the results page.

Possible Drawbacks

None

Applicable Issues

Fixes #1097

@darangi darangi marked this pull request as ready for review Nov 11, 2019
@darangi darangi requested a review from lkashef Nov 11, 2019
Copy link

@lkashef lkashef left a comment

@darangi all looking good, just make sure the test fails without your fix and you are good to go on merging this PR. Good job 🤩

@darangi
Copy link
Contributor Author

@darangi darangi commented Nov 12, 2019

@lkashef Thanks! The test fails without the fix 😃

@darangi darangi merged commit 5e73b59 into master Nov 14, 2019
2 checks passed
@MadLittleMods
Copy link

@MadLittleMods MadLittleMods commented Dec 9, 2019

Can this be pushed into a new release? 😇 I'm stuck scrolling over and over

@Aerijo
Copy link
Member

@Aerijo Aerijo commented Dec 9, 2019

@MadLittleMods I don't know where this particular PR is, but try out the beta or nightly channels if you want to use features sooner.

@MadLittleMods
Copy link

@MadLittleMods MadLittleMods commented Dec 9, 2019

@Aerijo The last release v0.219.1 is from 2019-11-1. How do I switch to the beta/nightly of the find-and-replace package? I don't see any beta tags there. I'm just assuming the find-and-replace package is updated independent of Atom releases?

Or are you referring to the Atom as a whole nightlies? https://blog.atom.io/2019/06/21/introducing-atom-nightly-releases.html (related https://blog.atom.io/2015/10/21/introducing-the-atom-beta-channel.html#a-note-to-package-authors)

@Aerijo
Copy link
Member

@Aerijo Aerijo commented Dec 9, 2019

Ah, in that case it hasn't even come to nightly yet (Atom as a whole). What you can do now is clone the repo, run apm install and then apm link at it's root directory to use the repo in it's current state. I believe the install step will require build tools installed on your computer, for any native modules. The linked package will take priority over the builtin version (after a reload), and running apm unlink find-and-replace will remove this linked version and the builtin will be used again.

@danialmuqris98

This comment has been minimized.

@lkashef lkashef deleted the maintain-scroll-position branch May 8, 2020
@mikkovedru
Copy link

@mikkovedru mikkovedru commented May 11, 2020

Doesn't this commit also fixes atom/atom#20259 ?

@nobodo
Copy link

@nobodo nobodo commented May 11, 2020

Not sure if related to this change, but a new quirk has appeared. When there are plenty of search results, collapse all, scroll down beyond the visible ones, then expand one and follow it, return back to search tab and then collapse that item, scroll to another position and expand some other result -> position jumps.

Seems to be related to scrolling; if I don't scroll, the expand/collapse within the visible items work just fine, but after scrolling a bit, the expand/collapse jumps the scrolled amount, so I guess it does not take the scrolled amount into account.

Happens also with nightly build (1.48.0-nightly2). Platform is macOS.

@stwr667
Copy link

@stwr667 stwr667 commented Sep 15, 2020

I get this too @nobodo. Really annoying when you're working through a big search list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants