New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regexp replacement highlighting #494

Merged
merged 2 commits into from Sep 30, 2015

Conversation

Projects
None yet
3 participants
@adamfranco
Contributor

adamfranco commented Aug 13, 2015

This pull request adds syntax-highlighting for regular expression replacement strings, first mentioned in #458 as a companion to syntax-highlighting for the regular expression search strings themselves.

Note that this is dependent on a new source.js.regexp.replacement grammar provided in adamfranco/language-javascript/regexp_replacement_grammar. I'll link to the pull request for that code once it has been submitted.

@adamfranco

This comment has been minimized.

Show comment
Hide comment
@adamfranco

adamfranco Aug 25, 2015

Contributor

@benogle , do you have any recommendations on how to set up tests to use language-javascript 0.89.0 or later? This feature is dependent on atom/language-javascript#198 , but that doesn't seem to be included in the code travice-ci is using.

Contributor

adamfranco commented Aug 25, 2015

@benogle , do you have any recommendations on how to set up tests to use language-javascript 0.89.0 or later? This feature is dependent on atom/language-javascript#198 , but that doesn't seem to be included in the code travice-ci is using.

@adamfranco adamfranco closed this Sep 1, 2015

@adamfranco adamfranco reopened this Sep 1, 2015

@50Wliu 50Wliu added the needs-review label Sep 1, 2015

@adamfranco

This comment has been minimized.

Show comment
Hide comment
@adamfranco

adamfranco Sep 30, 2015

Contributor

The support for this feature in the language-javascript package has now been included since atom-1.0.12 and tests are passing. I believe that this PR is ready for review.

Here is a screenshot of the current state, without this PR:
without-494

And here is a screenshot with this PR:
with-494

Contributor

adamfranco commented Sep 30, 2015

The support for this feature in the language-javascript package has now been included since atom-1.0.12 and tests are passing. I believe that this PR is ready for review.

Here is a screenshot of the current state, without this PR:
without-494

And here is a screenshot with this PR:
with-494

@benogle

This comment has been minimized.

Show comment
Hide comment
@benogle

benogle Sep 30, 2015

Contributor

👍 Merge away @50Wliu

Contributor

benogle commented Sep 30, 2015

👍 Merge away @50Wliu

50Wliu added a commit that referenced this pull request Sep 30, 2015

@50Wliu 50Wliu merged commit 3ad9160 into atom:master Sep 30, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adamfranco

This comment has been minimized.

Show comment
Hide comment
@adamfranco

adamfranco Sep 30, 2015

Contributor

Thanks! 😃

Contributor

adamfranco commented Sep 30, 2015

Thanks! 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment