New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix disabled replace buttons and their tooltips #542

Merged
merged 7 commits into from Oct 2, 2015

Conversation

Projects
None yet
1 participant
@benogle
Contributor

benogle commented Oct 2, 2015

Basically, this adds a tooltip when the replace buttons are disabled.

Previously, we were using the disabled attribute / prop on the buttons. This doesnt play well with the tooltips, which led to #501. This PR changes the buttons to use a disabled CSS class, which looks disabled, but gives us control. There are already guards in place to not allow replacing when no results resulting in a 'beep' (OS X bonk), so clicking a 'disabled' button will just 'beep'.

cc @atom/feedback if you have phrasing ideas on the disabled tooltip, that would be nice.

Fixes #530
Fixes #501
Fixes #504
Fixes #537

benogle added a commit that referenced this pull request Oct 2, 2015

Merge pull request #542 from atom/bo-fix-disabled
Fix disabled replace buttons and their tooltips

@benogle benogle merged commit 5e293b4 into master Oct 2, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment