Don't show find panel when doing cmd-e #796

Merged
merged 1 commit into from Oct 28, 2016

Conversation

Projects
None yet
3 participants
@vjeux
Contributor

vjeux commented Oct 15, 2016

There's a long standing issue where cmd-e shows the find panel where it shouldn't: #332

This pull request prevents the find panel from showing.

Test Plan:

  1. Click on new
  2. Press cmd-e, note that there is no visual feedback
  3. Press cmd-g multiple times to go through occurrences

See the behavior in Sublime:

In Atom with this pull request:

It even works the same way in Chrome!

Don't show find panel when doing cmd-e
There's a long standing issue where cmd-e shows the find panel where it shouldn't: #332

This pull request prevents the find panel from showing.

Test Plan:

1) Click on `new`
2) Press `cmd-e`, note that there is no visual feedback
3) Press `cmd-g` multiple times to go through occurrences

See the behavior in Sublime:
![](http://g.recordit.co/Iwt3rimsQM.gif)

In Atom with this pull request:
![](http://g.recordit.co/HMtN1TiJGr.gif)

It even works the same way in Chrome!
![](http://g.recordit.co/teDy4kCMYi.gif)
@maxbrunsfeld

This comment has been minimized.

Show comment
Hide comment
@maxbrunsfeld

maxbrunsfeld Oct 28, 2016

Contributor

Great. Thanks @vjeux.

Contributor

maxbrunsfeld commented Oct 28, 2016

Great. Thanks @vjeux.

@maxbrunsfeld maxbrunsfeld merged commit c263bf3 into atom:master Oct 28, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@vjeux

This comment has been minimized.

Show comment
Hide comment
Contributor

vjeux commented Oct 28, 2016

@maxbrunsfeld

This comment has been minimized.

Show comment
Hide comment
@maxbrunsfeld

maxbrunsfeld Oct 28, 2016

Contributor

This will be out in the next beta.

Contributor

maxbrunsfeld commented Oct 28, 2016

This will be out in the next beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment