Don't rely on destroyed markers preserving their ranges #837

merged 2 commits into from Jan 3, 2017


None yet

1 participant

maxbrunsfeld commented Jan 3, 2017 edited

When atom/text-buffer#193 lands, we will no longer track the ranges of destroyed markers. This requires a minor tweak in this package to query markers' ranges before destroying them.

/cc @nathansobo I could imagine community package authors having to make similar changes 😬

maxbrunsfeld added some commits Jan 3, 2017
@maxbrunsfeld maxbrunsfeld Don't rely on destroyed markers preserving their ranges 99adb9a
@maxbrunsfeld maxbrunsfeld Remove assertion about a destroyed editor's selected text
@maxbrunsfeld maxbrunsfeld merged commit bfd19ae into master Jan 3, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
continuous-integration/appveyor/pr AppVeyor build succeeded
@maxbrunsfeld maxbrunsfeld deleted the mb-dont-use-destroyed-markers-ranges branch Jan 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment