Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "Search in Directory" to "Search in Folder" #905

Merged
merged 1 commit into from Jan 8, 2019

Conversation

Projects
None yet
2 participants
@aninternetof
Copy link
Contributor

aninternetof commented May 29, 2017

Description of the Change

There is some inconsistency between us and tree-view in choosing the term "folder" or "directory" in the context menu. The "Search in Directory" context menu item is shown alongside tree-view's "New Folder" item. This PR changes our item to "Search in Folder" for consistency.

screenshot

Alternate Designs

Alternatively, we could have tree-view change its "Folder" items to say "Directory". But they have several, and we have one.

Benefits

It makes the resulting context menu more pleasing to read.

Possible Drawbacks

It looks like most of the internal code uses the word "directory", so the user-visible label will not match the internals, which is always unfortunate.

Applicable Issues

None.

Changes "Search in Directory" to "Search in Folder"
The "Search in Directory" context menu item is shown alongside tree-view's "New Folder" item. This changes our item to "Search in Folder" for consistency.
@daviwil

This comment has been minimized.

Copy link
Member

daviwil commented Jan 8, 2019

Thanks @aninternetof! I agree, this is more consistent with the other items in this context menu.

@daviwil daviwil merged commit f4d23de into atom:master Jan 8, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.