New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #950 #968

Merged
merged 1 commit into from Nov 1, 2017

Conversation

Projects
None yet
2 participants
@xream
Contributor

xream commented Nov 1, 2017

Fixed #950

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

Commands should be removed when the package is deactivated.

Benefits

Fixed #950

xream added a commit to xream/atom-project-neue that referenced this pull request Nov 1, 2017

@Ben3eeE Ben3eeE requested a review from 50Wliu Nov 1, 2017

@50Wliu

50Wliu approved these changes Nov 1, 2017

@50Wliu 50Wliu merged commit 229762a into atom:master Nov 1, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@50Wliu

This comment has been minimized.

Show comment
Hide comment
@50Wliu

50Wliu Nov 1, 2017

Member

Thanks!

Member

50Wliu commented Nov 1, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment