Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Don't watch TextEditors outside of the current project in Project Find #988
Description of the Change
To reproduce this, create a hierarchy something like
and open atom with
This PR adds a simple check to the
The subscriptions could be exclusively created with TextEditors that exist in the current project, but managing creating/disposing of those adds complexity and room for error.
Removes confusion/unintuitive behavior around finding and replacing.
May have become an anti-pattern, removal of which could cause confusion.
@anderoonies Thanks and just to clarify, this occurs between sibling folders as well - for example, assuming the project folder is
Doing a Search in Directory on
Sorry if your PR already addresses this, just wasn't sure.