New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exact starts-with should take precidence #41

Open
timscott opened this Issue Jun 3, 2014 · 12 comments

Comments

Projects
None yet
10 participants
@timscott

timscott commented Jun 3, 2014

To replicate:

  1. Open a tree containing files cox.rb and context.rb
  2. cmd-p and type "cox".
  3. Fuzzy finder lists context.rb above cox.rb

Perhaps not wrong but certainly surprising.

@alexrussell

This comment has been minimized.

Show comment
Hide comment
@alexrussell

alexrussell commented Jun 13, 2014

👍

@izuzak izuzak added the enhancement label Jun 13, 2014

@benzen

This comment has been minimized.

Show comment
Hide comment
@benzen

benzen commented Jun 26, 2014

👍

@collinbrewer

This comment has been minimized.

Show comment
Hide comment
@collinbrewer

collinbrewer Nov 11, 2014

👍 This is a must!

collinbrewer commented Nov 11, 2014

👍 This is a must!

@albertorestifo

This comment has been minimized.

Show comment
Hide comment
@albertorestifo

albertorestifo Dec 7, 2014

This feature is overdue in my opinion

albertorestifo commented Dec 7, 2014

This feature is overdue in my opinion

@bprosnitz

This comment has been minimized.

Show comment
Hide comment
@bprosnitz

bprosnitz Mar 9, 2015

+1 Exact searches sometimes don't match

bprosnitz commented Mar 9, 2015

+1 Exact searches sometimes don't match

@paulcsmith

This comment has been minimized.

Show comment
Hide comment
@paulcsmith

paulcsmith commented Mar 23, 2015

👍

@gdaolewe

This comment has been minimized.

Show comment
Hide comment
@gdaolewe

gdaolewe Oct 5, 2015

👍 Large project with a lot of files, exact matches are often buried by results that have several of the search characters but spread far apart. This makes fuzzy finder almost less useful than if it weren't fuzzy at all.

gdaolewe commented Oct 5, 2015

👍 Large project with a lot of files, exact matches are often buried by results that have several of the search characters but spread far apart. This makes fuzzy finder almost less useful than if it weren't fuzzy at all.

@benzen

This comment has been minimized.

Show comment
Hide comment
@benzen

benzen Oct 6, 2015

I would argue that it's quite frequent to prefer matching at the end of the
file path than anywhere at the begining.
I mean the file name it almost always the only part of the path that i can
recall

2015-10-05 17:11 GMT-04:00 gdaolewe notifications@github.com:

[image: 👍] Large project with a lot of files, exact matches are often
buried by results that have several of the search characters but spread far
apart. This makes fuzzy finder almost less useful than if it weren't fuzzy
at all.


Reply to this email directly or view it on GitHub
#41 (comment).

Benjamin DREUX

benzen commented Oct 6, 2015

I would argue that it's quite frequent to prefer matching at the end of the
file path than anywhere at the begining.
I mean the file name it almost always the only part of the path that i can
recall

2015-10-05 17:11 GMT-04:00 gdaolewe notifications@github.com:

[image: 👍] Large project with a lot of files, exact matches are often
buried by results that have several of the search characters but spread far
apart. This makes fuzzy finder almost less useful than if it weren't fuzzy
at all.


Reply to this email directly or view it on GitHub
#41 (comment).

Benjamin DREUX

@bronson

This comment has been minimized.

Show comment
Hide comment
@bronson

bronson Oct 10, 2015

Contributor

Related to #98 no doubt.

@izuzak this feels buggy to me. Not sure I agree with the enhancement label.

screen shot 2015-10-10 at 4 12 29 pm

Yes I want job_spec.rb... that's what I'm typing ain't it? :)

Contributor

bronson commented Oct 10, 2015

Related to #98 no doubt.

@izuzak this feels buggy to me. Not sure I agree with the enhancement label.

screen shot 2015-10-10 at 4 12 29 pm

Yes I want job_spec.rb... that's what I'm typing ain't it? :)

@timscott

This comment has been minimized.

Show comment
Hide comment
@timscott

timscott Oct 11, 2015

@broson Yes, this is the exact case. Because of this, a simple starts-with search would be better like 80% of the time.

timscott commented Oct 11, 2015

@broson Yes, this is the exact case. Because of this, a simple starts-with search would be better like 80% of the time.

@gdaolewe

This comment has been minimized.

Show comment
Hide comment
@gdaolewe

gdaolewe Oct 27, 2015

@benzen I agree that it should prefer matching the filename rather than the path, but it should prefer matching towards the beginning of the filename itself. If the matching is done on the full path + filename as one string, I think that's quite wrong.

I don't know how many I speak for, but I almost never type part of the path to find a file; the only reason I would is this exact scenario, where typing the filename exactly puts the desired file way down in the suggestions and I have to start typing the path to disambiguate.

gdaolewe commented Oct 27, 2015

@benzen I agree that it should prefer matching the filename rather than the path, but it should prefer matching towards the beginning of the filename itself. If the matching is done on the full path + filename as one string, I think that's quite wrong.

I don't know how many I speak for, but I almost never type part of the path to find a file; the only reason I would is this exact scenario, where typing the filename exactly puts the desired file way down in the suggestions and I have to start typing the path to disambiguate.

@benzen

This comment has been minimized.

Show comment
Hide comment
@benzen

benzen Oct 27, 2015

Maybe I badly explained myself, but I totally agree with @gdaolewe

benzen commented Oct 27, 2015

Maybe I badly explained myself, but I totally agree with @gdaolewe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment