New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefill query from selection #314

Merged
merged 9 commits into from Sep 13, 2017

Conversation

Projects
None yet
5 participants
@ColCh
Contributor

ColCh commented Aug 27, 2017

Description of the Change

When you select text, then activate fuzzy-finder, it will look for selection in active editor.

If there is some text selected, it will use it as query - and select text inside of query as well

Alternate Designs

Didn't noticed any. Only in Nuclide's nuclide-quick-open there is analogue for it, but you can't use it without installing entire nuclide package

Benefits

Now you don't need to Copy-Paste your selection in fuzzy finder.

This speedups programming performance :)

Possible Drawbacks

May be opened a bit* slowly, because it looks for editor selected text

  • didn't benchmarked... Also, didn't noticed any performance drop on my machine (MBP 2015)

Applicable Issues

resolves #161

@lee-dohm

This comment has been minimized.

Show comment
Hide comment
@lee-dohm

lee-dohm Sep 5, 2017

Member

We are interested in taking this feature. We need two modifications first:

  1. We need this functionality behind a configuration option
  2. We need to default to the current behavior (so default to off)

Once that's done, we'll take a deeper look.

Thanks for the submission!

Member

lee-dohm commented Sep 5, 2017

We are interested in taking this feature. We need two modifications first:

  1. We need this functionality behind a configuration option
  2. We need to default to the current behavior (so default to off)

Once that's done, we'll take a deeper look.

Thanks for the submission!

ColCh added some commits Sep 5, 2017

Merge branch 'master' into prefill-from-selection
* master:
  Decaffeinate lib/path-loader.coffee
  🎨 Use fat arrow function syntax
  👕 Remove unused assignment
  👕 Remove unused assignment
  Decaffeinate spec/fuzzy-finder-spec.coffee
  Remove obsolete shim for atom.workspace.getCenter()
  Decaffeinate lib/main.coffee
  Decaffeinate lib/load-paths-handler.js
  Decaffeinate lib/helpers.coffee
  Decaffeinate lib/file-icons.coffee
  Decaffeinate lib/default-file-icons.coffee
@ColCh

This comment has been minimized.

Show comment
Hide comment
@ColCh

ColCh Sep 5, 2017

Contributor

Done.

Now this behaviour is turned on by config variable.
And this config variable is turned off by default, meaning current behaviour.
Also, I've merged master changer with decaffeinated files.

Please review, ping @lee-dohm

Contributor

ColCh commented Sep 5, 2017

Done.

Now this behaviour is turned on by config variable.
And this config variable is turned off by default, meaning current behaviour.
Also, I've merged master changer with decaffeinated files.

Please review, ping @lee-dohm

@smashwilson

This comment has been minimized.

Show comment
Hide comment
@smashwilson

smashwilson Sep 13, 2017

Member

👍 Works like a charm. Thanks for the contribution! 🎉

Member

smashwilson commented Sep 13, 2017

👍 Works like a charm. Thanks for the contribution! 🎉

@smashwilson smashwilson merged commit 820af9e into atom:master Sep 13, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ColCh

This comment has been minimized.

Show comment
Hide comment
@ColCh

ColCh Sep 13, 2017

Contributor

@smashwilson great! Thank you!

Contributor

ColCh commented Sep 13, 2017

@smashwilson great! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment