New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up JavaScript linter #323

Merged
merged 11 commits into from Sep 14, 2017

Conversation

Projects
None yet
2 participants
@jasonrudolph
Member

jasonrudolph commented Sep 5, 2017

Configure linter for JavaScript Standard Style to ensure consistency with the Atom style guide.

TODO

  • Remove obsolete CoffeeScript linter config, now that all of this package's CoffeeScript has been converted to JavaScript
  • Set up JavaScript Standard Style linter
  • Resolve any linter violations

jasonrudolph added some commits Sep 4, 2017

🔥 Remove obsolete coffeescript linter configuration
Now that all of this package's code has been converted from CoffeeScript
to JavaScript, we no longer need the CoffeeScript linter.
👕 Silence linter re: unnecessary return statement
Prior to this change, `standard` reported the following linter failure:

  lib/fuzzy-finder-view.js:248:7: Unnecessary return statement.
(no-useless-return)

This return statement _might_ be used to short-circuit the method, so
let's tell the linter to ignore it for now.
👕 Fix linter failure re: '===' vs. '=='
Fixes the following error:

  lib/fuzzy-finder-view.js:260:51: Expected '===' and instead saw '=='.
👕 Ignore no-unused-vars violations
These variables are "unused", but they're *useful* for the readability
of the tests, so let's tell the linter to ignore these violations.

@jasonrudolph jasonrudolph changed the title from [WIP] Set up JavaScript linter to Set up JavaScript linter Sep 6, 2017

@smashwilson

This comment has been minimized.

Show comment
Hide comment
@smashwilson

smashwilson Sep 14, 2017

Member

👍 👕

Member

smashwilson commented Sep 14, 2017

👍 👕

@smashwilson smashwilson merged commit e37ab6e into master Sep 14, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@smashwilson smashwilson deleted the jr-standard-linter branch Sep 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment