New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track visited inodes in load-paths-handler to prevent looping #331

Merged
merged 1 commit into from Nov 3, 2017

Conversation

Projects
None yet
1 participant
@nathansobo
Contributor

nathansobo commented Nov 3, 2017

Fixes #329

This replaces the existing logic which attempted to detect "internal symlinks". We simply keep a set of every inode number we have visited and make sure we don't visit the same node twice when traversing through symbolic links.

Track visited inodes in load-paths-handler to prevent looping
This replaces the existing logic which attempted to detect "internal
symlinks".

@nathansobo nathansobo merged commit 776344b into master Nov 3, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@nathansobo nathansobo deleted the track-visited-inodes branch Nov 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment