Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Use fuzzy-finder to open remote editors in Teletype portals #335
Description of the Change
atom/teletype-client#52 teaches the teletype package to provide a service that other packages can consume to get the list of remote editors that are available when a person is a guest in one or more portals. This pull request teaches the fuzzy-finder package to consume that service (if the teletype package is installed and enabled). Together, these pull requests deliver the following functionality for atom/teletype#268:
The UI/UX is modeled after the mockup in 2b of atom/teletype#268 (comment). (Note that in addition to updating the fuzzy-finder, that mockup includes updates to the tree-view and the file tabs as well. We're interested in exploring those updates, but since this is a pull request on atom/fuzzy-finder, those other updates are out of scope for this pull request.)
Rolling out this change
The fuzzy-finder package is bundled with Atom. The teletype package is not yet bundled with Atom. The fuzzy-finder will continue to provide its normal behavior if teletype isn't present or if the user has an older version of teletype that doesn't expose the teletype service. Similarly, teletype will continue to provide its normal behavior if the user has an older version of fuzzy-finder that doesn't consume teletype's service. That said, we'd like to make this functionality available sooner rather than later.
After testing this locally it seems to be working quite well.
@simurai: I would love to get your feedback on this. Please, feel free to add commits to this branch until you feel like the design is
I can't get it to work,
Anyways, I just used
Added some extra padding, for very long names:
Correct, long-term we will want to show all the files in the remote workspace/project, but for now you're only allowed to see the currently open buffers.