New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate line numbers before jumping #338

Merged
merged 2 commits into from Feb 18, 2018

Conversation

Projects
None yet
1 participant
@50Wliu
Member

50Wliu commented Feb 18, 2018

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

Only attempt to jump to a specific line number if the text after the colon is a valid line number. Otherwise, show an error if appropriate and just jump to the file but don't change the cursor position.

Alternate Designs

None.

Benefits

Line number validation and no more uncaught exceptions related to that.

Possible Drawbacks

None?

Applicable Issues

Fixes #308

50Wliu added some commits Feb 18, 2018

@50Wliu 50Wliu merged commit 638d240 into master Feb 18, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@50Wliu 50Wliu deleted the wl-validate-line-numbers branch Feb 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment