Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature to jump to columns within text lines #360

Merged
merged 4 commits into from Jan 24, 2019

Conversation

Projects
None yet
4 participants
@jtagscherer
Copy link
Contributor

jtagscherer commented Oct 31, 2018

Issue or RFC Endorsed by Atom's Maintainers

#115

Description of the Change

Previously, a user could request to jump to a specific line of a file or within the current editor by entering a colon followed by the line number into the fuzzy finder. This pull request enhances this feature by adding functionality to jump to a specific column within that line using a second colon. For example, file.js:4:6 would open file.js and move the cursor to column six of line four. If the user has not specified a valid column number, Atom behaves in the same way as before the introduction of this enhancement and jumps to the first character within the specified line.

Important Note: I fixed a bug within the fuzzy finder status messages in pull request #359. These changes will need to be pulled into this pull request and adapted to the new functionality before merging.

Alternate Designs

N/A

Possible Drawbacks

As far as I'm aware, there are no drawbacks since this functionality is of a purely additional nature. If the user only wants to jump to a line like in the old version, they can simply omit the second colon and Atom will behave just like before.

Verification Process

I have tried out jumping to lines, both within an open editor and while jumping to another file. I did so both with and without additional column numbers, as well as invalid entries, in all possible combinations. I concluded that previous behaviour remains unchanged while the new functionality behaves as expected.

Furthermore, all existing regression tests ran successfully. These include test cases for a variety of different environment and input conditions. I recombined all of them with the ability of specifying column numbers, creating a set of new test cases for the newly added functionality. These run successfully as well.

Release Notes

Added a feature to jump to a column of a line using a second colon, e.g. file.js:4:6

@jtagscherer jtagscherer force-pushed the jtagscherer:feature/jumpToColumn branch from cdd7bb0 to 9455b8f Oct 31, 2018

@jtagscherer jtagscherer force-pushed the jtagscherer:feature/jumpToColumn branch from 9455b8f to ef2431b Oct 31, 2018

@rsese

This comment has been minimized.

Copy link
Member

rsese commented Nov 2, 2018

Thanks! Someone from the team will take a look as soon as they can.

@lee-dohm lee-dohm added the triaged label Nov 19, 2018

@smashwilson
Copy link
Member

smashwilson left a comment

👍 Looks good, works well. 😄

@smashwilson smashwilson merged commit d9c5b16 into atom:master Jan 24, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.