Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Add feature to jump to columns within text lines #360
Issue or RFC Endorsed by Atom's Maintainers
Description of the Change
Previously, a user could request to jump to a specific line of a file or within the current editor by entering a colon followed by the line number into the fuzzy finder. This pull request enhances this feature by adding functionality to jump to a specific column within that line using a second colon. For example,
Important Note: I fixed a bug within the fuzzy finder status messages in pull request #359. These changes will need to be pulled into this pull request and adapted to the new functionality before merging.
As far as I'm aware, there are no drawbacks since this functionality is of a purely additional nature. If the user only wants to jump to a line like in the old version, they can simply omit the second colon and Atom will behave just like before.
I have tried out jumping to lines, both within an open editor and while jumping to another file. I did so both with and without additional column numbers, as well as invalid entries, in all possible combinations. I concluded that previous behaviour remains unchanged while the new functionality behaves as expected.
Furthermore, all existing regression tests ran successfully. These include test cases for a variety of different environment and input conditions. I recombined all of them with the ability of specifying column numbers, creating a set of new test cases for the newly added functionality. These run successfully as well.
Added a feature to jump to a column of a line using a second colon, e.g.