Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return a promise instead of using waitsFor #377

Merged
merged 1 commit into from Apr 3, 2019

Conversation

Projects
None yet
2 participants
@rafeca
Copy link
Contributor

commented Apr 3, 2019

Sending this PR to check if it improves the flakiness reported in atom/atom#19095

@rafeca rafeca force-pushed the attempt-to-improve-tests branch from b787907 to ee38e5e Apr 3, 2019

@rafeca rafeca force-pushed the attempt-to-improve-tests branch from ee38e5e to 74d19aa Apr 3, 2019

@rafeca rafeca changed the title WIP: Return a promise instead of using waitsFor Return a promise instead of using waitsFor Apr 3, 2019

@rafeca rafeca marked this pull request as ready for review Apr 3, 2019

@jasonrudolph

This comment has been minimized.

Copy link
Member

commented Apr 3, 2019

I'm ok living with the mystery 😅

😆

This seems like it's worth shipping to me. The apparent reduction in flakiness feels promising. 🤞

@rafeca rafeca merged commit ba72696 into master Apr 3, 2019

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@rafeca rafeca deleted the attempt-to-improve-tests branch Apr 3, 2019

@rafeca

This comment has been minimized.

Copy link
Contributor Author

commented Apr 3, 2019

It seems like the builds on #378 have started passing consistently after merging this (they were quite flaky before).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.