Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure that cursor position is centered after navigating to a line #385

Merged
merged 1 commit into from May 8, 2019

Conversation

Projects
None yet
1 participant
@rafeca
Copy link
Contributor

commented May 7, 2019

Description of the Change

In a similar way that atom/atom#19272 fixed the scroll position after opening atom from the command line, this change does the same for the fuzzy finder. This way we have a consistent user experience for both scenarios.

The two main changes of this PR are:

  • The selected line will get vertically centered in the editor.
  • If the line is folder, it'll get unfolded.

Before this change

before

With this change*

after

Alternate Designs

Do not do anything.

Benefits

Consisten user experience when navigating to a line through the fuzzy finder.

Possible Drawbacks

N/A

Applicable Issues

atom/atom#12253

@rafeca rafeca merged commit 367bfae into master May 8, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rafeca rafeca deleted the center-scroll-when-navigating-to-line branch May 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.