Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show fast mode prompt on any project size #394

Merged
merged 2 commits into from May 29, 2019

Conversation

Projects
None yet
2 participants
@rafeca
Copy link
Contributor

commented May 28, 2019

This PR is a follow-up of #378 to get more people opting in to the fast mode.

Context

Now that the fuzzy finder fast mode has been out for a couple of weeks in Atom v1.37 without any major issues, I’d like to open the gates a bit more to the feature to get more feedback from it before making it the default one.

The current plan is the following:

  • Atom v1.37: Show prompt to enable it on large projects. (done)
  • Atom v1.38: Show prompt to enable it on any project.
  • Atom v1.39: Remove prompt and enable it by default.

Doing this will give us much more signal about the fast mode on Atom v1.38 before enabling it by default (since currently we only have ~0.5% of users with ripgrep enabled).

Note: Due to our release cadence, I'll need to cherry-pick the new version of the fuzzy-finder package on the release-1.38 branch, but that should be fine.

@rafeca rafeca requested review from nathansobo and as-cii May 28, 2019

@rafeca rafeca force-pushed the show-prompt-always branch from 15468da to 1e36f7c May 28, 2019

@as-cii

as-cii approved these changes May 29, 2019

Copy link
Member

left a comment

Looks good! ⚡️

@rafeca rafeca merged commit 6da0f45 into master May 29, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rafeca rafeca deleted the show-prompt-always branch May 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.