Ignore VCS directories even when they are not in ignoreNames #399
Hi, this is my very first PR for Atom's core system !
If an user's
Because those files are usually regarded as VCS-ignored files and more over, the previous
Please refer to #379 (comment) for more detail.
Description of the Change
Only 5 line changes: Add
To include those files, an user need to disable both
Wow, this was fast!! Thanks a lot for the PR!
Don't worry about the failure on travis, it's not caused by this PR.
Can you also add a test, so this behaviour does not get broken in the future? You can add it just below this test:
You can use that test as an inspiration, and do something like
I think it's such a rare case to want to search inside the
I'm welcome to write specs !
Yeah, I totally agree with you and the alternative also sounds sane.
I've not created a spec for the case when
rafeca left a comment
This is awesome!
Thanks a lot for this PR, and congratulations for your first contribution to Atom! I hope that many more will come afterwards
I'm going to merge it and publish a new version of the fuzzy finder package. This fix will probably be available on v1.39 (since I'll cherry-pick this along some other stuff from fuzzy finder to the current beta).