Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make fast mode the default mode and remove prompt #401

Merged
merged 2 commits into from Jun 26, 2019

Conversation

Projects
None yet
2 participants
@rafeca
Copy link
Contributor

commented Jun 26, 2019

Looks like we haven't got any major negative feedback during the opt-in period of the fast mode (more info here), and the performance results are extremely positive from people opting in: between 5X and 15X faster depending on the project size:

Screenshot 2019-06-26 at 11 02 37

Based on that, we've decided to make the fast mode the default mode on fuzzy finder and remove the opt-in prompt. We're going to leave the config options to allow user to revert to the old behaviour for a while, just to get some time for some potential obscure edge cases to pop out.

I'm planning to release a new version of the fuzzy finder once this PR gets merged and cherry pick the new version into the Atom v1.39 release

@rafeca rafeca requested a review from jasonrudolph Jun 26, 2019

@rafeca rafeca merged commit 2e7c9a6 into master Jun 26, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rafeca rafeca deleted the ripgrep-default branch Jun 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.