New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show PR build statuses #1084

Merged
merged 48 commits into from Aug 14, 2017

Conversation

Projects
None yet
4 participants
@kuychaco
Member

kuychaco commented Aug 4, 2017

This PR implements the query and display of build statuses for pull requests.

BinaryMuse added some commits Aug 4, 2017

Improve PR build status display
Includes summary sentence, donut chart, and general styling improvements

BinaryMuse added some commits Aug 10, 2017

@BinaryMuse

This comment has been minimized.

Show comment
Hide comment
@BinaryMuse

BinaryMuse Aug 11, 2017

Member

As we started on this PR, it grew in scope a little bit:

  • Merged in #999, which brought in the latest version of Relay
  • Merged in #924 early, which included some changes to the way we group timeline events of the same type that we wanted to include
  • Updated the entire application to use Relay modern (first switching to relay/compat and then moving to the modern core)
Member

BinaryMuse commented Aug 11, 2017

As we started on this PR, it grew in scope a little bit:

  • Merged in #999, which brought in the latest version of Relay
  • Merged in #924 early, which included some changes to the way we group timeline events of the same type that we wanted to include
  • Updated the entire application to use Relay modern (first switching to relay/compat and then moving to the modern core)

BinaryMuse and others added some commits Aug 11, 2017

Refresh PrStatusesContainer intelligently based on commit status
PRs/commits with pending status contexts will refresh more often than
ones without
Don't refresh PR pane items
Deferring this until the pagination problem is solved
@BinaryMuse

This comment has been minimized.

Show comment
Hide comment
@BinaryMuse

BinaryMuse Aug 13, 2017

Member

@kuychaco What do you think about merging this now and taking care of the pagination issue in a future PR?

Member

BinaryMuse commented Aug 13, 2017

@kuychaco What do you think about merging this now and taking care of the pagination issue in a future PR?

@GoAlexander

Test

BinaryMuse added some commits Aug 14, 2017

@BinaryMuse BinaryMuse merged commit daf0b55 into master Aug 14, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@BinaryMuse BinaryMuse deleted the ku-whats-the-status branch Aug 14, 2017

@BinaryMuse BinaryMuse referenced this pull request Aug 22, 2017

Closed

⬆ github@0.5.0-0 #15412

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment