New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encode/decode file name and working directory in opener URI #1217

Merged
merged 2 commits into from Oct 16, 2017

Conversation

Projects
None yet
3 participants
@kuychaco
Member

kuychaco commented Oct 13, 2017

Fixes #1177
Fixes #1179

@kuychaco kuychaco requested a review from BinaryMuse Oct 14, 2017

@the-j0k3r

This comment has been minimized.

Show comment
Hide comment
@the-j0k3r

the-j0k3r Oct 15, 2017

Nice, please backport to 1.21.x branch too :)

the-j0k3r commented Oct 15, 2017

Nice, please backport to 1.21.x branch too :)

@kuychaco kuychaco merged commit b77d677 into master Oct 16, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kuychaco kuychaco deleted the ku-show-diff-when-filenames-have-spaces branch Oct 16, 2017

@the-j0k3r

This comment has been minimized.

Show comment
Hide comment
@the-j0k3r

the-j0k3r Oct 17, 2017

Would it be desired to exclude images from attempting to display a diff? ATM the same issue applies to images and just throwing the idea out there.

the-j0k3r commented Oct 17, 2017

Would it be desired to exclude images from attempting to display a diff? ATM the same issue applies to images and just throwing the idea out there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment