New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable all relevant color options when executing Git commands #1254

Merged
merged 5 commits into from Nov 27, 2017

Conversation

Projects
None yet
2 participants
@BinaryMuse
Member

BinaryMuse commented Nov 17, 2017

In lieu of an environment variable or some other global --no-color option, this PR adds command line arguments to every Git command that sets all relevant color options to false (which is equivalent to never for options that take it).

Fixes #977

BinaryMuse added some commits Nov 17, 2017

@BinaryMuse

This comment has been minimized.

Show comment
Hide comment
@BinaryMuse

BinaryMuse Nov 17, 2017

Member

An alternative approach would be to find all the invocations of the specific commands that take a --no-color option (like status and diff) and add the arguments there, but this strategy makes sure we don't miss any. Open to additional 💭 s.

Member

BinaryMuse commented Nov 17, 2017

An alternative approach would be to find all the invocations of the specific commands that take a --no-color option (like status and diff) and add the arguments there, but this strategy makes sure we don't miss any. Open to additional 💭 s.

kuychaco and others added some commits Nov 9, 2017

@BinaryMuse BinaryMuse merged commit abc8bc9 into master Nov 27, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@BinaryMuse BinaryMuse deleted the mkt-never-use-color branch Nov 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment