New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test for async confirm #1257

Merged
merged 6 commits into from Nov 27, 2017

Conversation

Projects
None yet
3 participants
@50Wliu
Member

50Wliu commented Nov 19, 2017

Please be sure to read the contributor's guide to the GitHub package before submitting any pull requests.

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

Needed for atom/atom#16229, in which the unsaved changes dialog has been changed to be async.

Alternate Designs

None.

Benefits

Keep specs passing.

Possible Drawbacks

None.

Applicable Issues

atom/atom#16229

50Wliu added some commits Nov 19, 2017

@50Wliu

This comment has been minimized.

Show comment
Hide comment
@50Wliu

50Wliu Nov 19, 2017

Member

Appveyor failures are the same on master.

Member

50Wliu commented Nov 19, 2017

Appveyor failures are the same on master.

kuychaco and others added some commits Nov 9, 2017

@BinaryMuse BinaryMuse merged commit 0bec644 into master Nov 27, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@BinaryMuse

This comment has been minimized.

Show comment
Hide comment
@BinaryMuse
Member

BinaryMuse commented Nov 27, 2017

Thanks, @50Wliu

@BinaryMuse BinaryMuse deleted the wl-async-confirm branch Nov 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment