New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Great Unflaking, Part II #1317

Merged
merged 11 commits into from Feb 23, 2018

Conversation

Projects
None yet
1 participant
@smashwilson
Member

smashwilson commented Feb 22, 2018

This one's less frequent, but still annoying.

Fixes #1162.

smashwilson added some commits Feb 22, 2018

Try using allowHalfOpen and .end()
I feel like there's some reason we haven't done this already, but I
don't remember why at all.

@smashwilson smashwilson merged commit 109a065 into master Feb 23, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@smashwilson smashwilson deleted the flag-file-flake branch Feb 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment