Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Recent commit changes RFC #1318
A more formal proposal of the "recent commits" view displayed beneath the mini commit editor.
Previous discussion and design ideating are available in #554.
referenced this pull request
Feb 23, 2018
Here a few dividers:
Hmm.. not sure. They use quite some space for such a small area and it's not clear if they are referring to the commits above or below a divider. Might fit better for the more fully-featured history log panel.
Alternatively we could have up/down arrows on the commits, matching the ahead/behind in the status-bar:
And tags could also be attached to a commit:
Looking over the options, some thoughts:
Hey all! @donokuda asked me to take a look here because of the overlap in problem space with some things we're working on at GHD.
Taking a look at the options you have here, I really like the icons direction. I think it does the best job working within the small timeline here. But, I think there might be a clearer icon to use than the up/down arrow. To me at least, the up/down arrow is pretty strongly associated with the push/pull action, not necessarily with the commit itself in terms of "this commit is ahead of my branch"
It would be awesome to come up with a new icon that we can use (here and in GHD!) to signal "this commit is ahead/behind your branch" Maybe something like
Hope this is helpful! Let me know if I can clarify anything :)
Here a few refs below and aligned with the message:
If they would be above, it might look like they belong to the commit above. We could also add divider lines for each commit, but then it quickly looks more heavy.
Hmm... also I think having these refs on a 2nd line makes messages less scannable because you get interrupted with something different when scrolling. How important is it to see these refs in the recent commits? I can see two options:
The up/down arrows would be more from a local/remote perspective. Like this cheesy way of thinking that the remote is somewhere up in the cloud. Kinda like downloading and uploading.
Looking at the up/down arrows, people might try to click them to actually push/pull?
And here the 2nd suggestion visualized:
We've completed Phases 1 and 2 with Phase 3 almost complete. With that we've reached our near-term goals for this feature
The rest is icing and we'll hold off until future quarters in order to prioritize progress on other roadmap items. I'll go ahead and merge this now so that we can save all of the goodness to refer to when we pick this back up again.
Thanks everyone for your fabulous input!