New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbreak master #1321

Merged
merged 6 commits into from Feb 24, 2018

Conversation

Projects
None yet
2 participants
@smashwilson
Member

smashwilson commented Feb 24, 2018

Turns out it's useful to actually try your changes before you merge the PR, even if the tests are green. Who knew! 馃尃

@simurai: it looks like the markup changed within the git tab hierarchy because I moved our React/Etch boundary. I think I have it looking okay again, but if you don't mind having a look to see if there's a better way to do it when you get the change, it would be much appreciated 馃檱

kuychaco added some commits Feb 24, 2018

@smashwilson smashwilson merged commit 6ca2ee5 into master Feb 24, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@smashwilson smashwilson deleted the unbreak-master branch Feb 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment