New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid rerendering the FilePatchView on every tiny update #1347

Merged
merged 4 commits into from Mar 12, 2018

Conversation

Projects
None yet
1 participant
@smashwilson
Member

smashwilson commented Mar 12, 2018

Use a shouldComponentUpdate() method to prevent the FilePatchView from re-rendering every time a change is triggered. This is especially egregrious now that the CommitView's editor triggers a Repository update event on each keystroke by way of setRegularCommitMessage().

Fixes #1338.

smashwilson added some commits Mar 12, 2018

@smashwilson smashwilson merged commit 86e29c0 into master Mar 12, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@smashwilson smashwilson deleted the should-component-update branch Mar 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment