New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More prominent commit button #1349

Merged
merged 1 commit into from Mar 13, 2018

Conversation

Projects
None yet
1 participant
@simurai
Member

simurai commented Mar 13, 2018

Description of the Change

This makes the commit button look more prominent (btn-primary).

Before After
screen shot 2018-03-13 at 9 18 12 am screen shot 2018-03-13 at 9 05 39 am

Benefits

  • Guides the user more towards the main action on the panel -> committing.
  • Also adds more contrast to the otherwise somewhat "flat" UI.
  • More aligned with GitHub Desktop. /cc @donokuda

Possible Drawbacks

None I can think of.

@simurai simurai merged commit 39d21d0 into master Mar 13, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@simurai simurai deleted the sm-primary-commit-button branch Mar 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment