New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use unambiguous branch name when pushing #1359

Merged
merged 1 commit into from Mar 19, 2018

Conversation

Projects
None yet
2 participants
@iPherian
Contributor

iPherian commented Mar 19, 2018

Description of the Change

When pushing, use unambiguous "refs/heads/branch_name" instead of "branch_name"

Benefits

Avoids ambiguity with other kinds of git refs like tags. git push will fail if a ref string refers to more than one thing. Fixes #1358

Applicable Issues

#1358

@smashwilson

This comment has been minimized.

Member

smashwilson commented Mar 19, 2018

👍 Cool, nice catch.

@smashwilson smashwilson merged commit d3b2b67 into atom:master Mar 19, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment