New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flakey GitTabController test #1362

Merged
merged 1 commit into from Mar 22, 2018

Conversation

Projects
None yet
2 participants
@kuychaco
Member

kuychaco commented Mar 22, 2018

Async operations were causing a race condition. The solution was to await promises for the staging operation and selection update.

Fix flakey GitTabController test - await operation promises
Co-authored-by: Tilde Ann Thurium <annthurium@github.com>

@annthurium annthurium merged commit f1da475 into master Mar 22, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@annthurium annthurium deleted the ku-tt-fix-flake branch Mar 22, 2018

@kuychaco

This comment has been minimized.

Member

kuychaco commented Mar 23, 2018

@annthurium congrats on your first! 🚢 :shipit: 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment