New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Enzyme 3 #1386

merged 36 commits into from Apr 12, 2018


None yet
1 participant

smashwilson commented Apr 11, 2018

Enzyme 3 is a total rewrite that supports a broad range of React versions by means of an "adapter". I'm splitting this out of #1174 in hopes of being able to get us back on the latest stable React in smaller chunks of work.

Almost all of the failures I've hit so far have been what @BinaryMuse identified at #1174 (comment), by which I mean "apply .update() generously". Hopefully by now all of the blockers that she identified in that issue have been ironed out upstream? 馃 It certainly looks like the issues she linked are closed, at least.

Remaining failures
  • CommitController
  • EditorConflictController
  • FilePatchController
  • GitTabController
  • RepositoryConflictController
  • RootController
  • StatusBarTileController
  • ObserveModelDecorator
  • CloneDialog
  • CoAuthorForm
  • CommitView
  • FilePatchView
  • InitDialog

smashwilson added some commits Apr 11, 2018

smashwilson added some commits Apr 12, 2018

@smashwilson smashwilson merged commit 5f0bf0e into master Apr 12, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed

@smashwilson smashwilson deleted the aw/enzyme-up branch Apr 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment