New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

React 16.3.1 #1390

Merged
merged 47 commits into from Apr 17, 2018

Conversation

Projects
None yet
2 participants
@smashwilson
Member

smashwilson commented Apr 13, 2018

Upgrade us to React 16.3.1 馃殌 馃寯

I'm intending to merge this when I've dealt with all test failures and newly introduced deprecations, but I won't be tackling the use of any new features introduced by React 16 just yet, to keep this from sprawling.

  • Update <Portal> components to use the official ReactDOM.createPortal(), and the corresponding tests to use Enzyme
    • PaneItem
    • Decoration
    • DockItem
    • Panel
    • Tooltip
  • Actually test it all out live

Supersedes #1174.

@smashwilson

This comment has been minimized.

Member

smashwilson commented Apr 13, 2018

21 failures! Not bad. This should be faster than the Enzyme upgrade was (he says hopefully).

smashwilson added some commits Apr 13, 2018

@smashwilson

This comment has been minimized.

Member

smashwilson commented Apr 13, 2018

@kuychaco by the way, since it looks like I'll be revisiting Tooltip as part of the upgrade anyway, want me to tackle this?

// TODO: [ku 4/9/2018] fix tooltip target method (we're using `document.querySelector` because

smashwilson added some commits Apr 13, 2018

@kuychaco

This comment has been minimized.

Member

kuychaco commented Apr 13, 2018

@smashwilson sure go for it! When I took a stab at it, I hit a snag with the push/pull tooltips FYI. Thanks for taking this on!

smashwilson added some commits Apr 13, 2018

smashwilson added some commits Apr 16, 2018

@smashwilson smashwilson merged commit 6b0bfd7 into master Apr 17, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@smashwilson smashwilson deleted the aw/react-up branch Apr 17, 2018

@smashwilson

This comment has been minimized.

Member

smashwilson commented Apr 17, 2018

馃帀 馃帀 馃帀

@atom/github-package: I've fixed all of the failing tests from our suite and I've addressed the problems I noticed in dev mode, but it's quite possible that there are other regressions that I didn't catch. (Yes, this probably means we need a better test suite 馃憖)

smashwilson added a commit that referenced this pull request Apr 19, 2018

Remove obsolete `this.refs.gitTab` reference
I already took care of this on master as part of #1390, too, so we're
good there.

Fixes #1399.

smashwilson added a commit that referenced this pull request May 7, 2018

Remove obsolete `this.refs.gitTab` reference
I already took care of this on master as part of #1390, too, so we're
good there.

Fixes #1399.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment