New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🛠Replace uses of ObserveModelDecorator with ObserveModel #1393

Merged
merged 15 commits into from Apr 18, 2018

Conversation

Projects
None yet
1 participant
@smashwilson
Member

smashwilson commented Apr 17, 2018

We went through a few iterations of ways to deal with giving React components access to Repository data, given that Repositories return just about everything in Promises. The Latest and Greatest is an ObserveModel, which uses a render prop to get the job done. It's pretty slick!

I'm going to do a quick pass through the repo and update code that's still using the decorator to use the new view.

Component list
  • GitTabController
  • RemotePrController
  • RepositoryConflictController
Remaining tasks
  • Try it out live ⚡️
  • Tests green

smashwilson added some commits Apr 17, 2018

smashwilson added some commits Apr 18, 2018

@smashwilson smashwilson merged commit 928acce into master Apr 18, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@smashwilson smashwilson deleted the aw/observe-model branch Apr 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment